linux-kernel - Re: [PATCH 5/5] input: i8042 - add runtime check in x86's i8042_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C2E52DD.2050306@zytor.com>
Date:	Fri, 02 Jul 2010 13:58:05 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	"Luck, Tony" <tony.luck@...el.com>
CC:	Feng Tang <feng.tang@...el.com>, linux-kernel@...r.kernel.org,
	mingo@...e.hu, jacob.jun.pan@...el.com, dtor@...l.ru,
	randy.dunlap@...cle.com
Subject: Re: [PATCH 5/5] input: i8042 - add runtime check in x86's i8042_platform_init

[Cc: Tony Luck]

On 07/02/2010 01:53 PM, Thomas Gleixner wrote:
> On Fri, 2 Jul 2010, feng.tang@...el.com wrote:
> 
>> From: Feng Tang <feng.tang@...el.com>
>>
>> Then it will first check x86_platforms's i8042 detection result,
>> then go on with normal probe.
>>
>> Cc: Dmitry Torokhov <dtor@...l.ru>
>> Signed-off-by: Feng Tang <feng.tang@...el.com>
>> ---
>>  drivers/input/serio/i8042-x86ia64io.h |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
>> index 6168469..2e14fc5 100644
>> --- a/drivers/input/serio/i8042-x86ia64io.h
>> +++ b/drivers/input/serio/i8042-x86ia64io.h
>> @@ -840,6 +840,10 @@ static int __init i8042_platform_init(void)
>>  {
>>  	int retval;
>>  
>> +	/* Just return if pre-detection shows no i8042 controller exist */
>> +	if (!x86_platform.i8042_detect())
>> +		return -ENODEV;
> 
> That's going to break IA64 :(
> 

I have to say there is an awful lot of code in that file which is
specific to x86 (more so than IA64)... anyone has a feel if it would
make sense to break it up?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/