linux-kernel - Re: [PATCH 21/25] vme_ca91cx42: remove casts from void*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C31B620.4060301@ge.com>
Date:	Mon, 05 Jul 2010 11:38:24 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	Kulikov Vasiliy <segooon@...il.com>
CC:	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	devel@...verdev.osuosl.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Julia Lawall <julia@...u.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/25] vme_ca91cx42: remove casts from void*

Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
>   
Seems ok, cheers,

Signed-off-by: Martyn Welch <martyn.welch@...com>


> ---
>  drivers/staging/vme/bridges/vme_ca91cx42.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
> index 0c82eb4..ce05ffa 100644
> --- a/drivers/staging/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
> @@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>  
>  	if (dest->type == VME_DMA_VME) {
>  		entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
> -		vme_attr = (struct vme_dma_vme *)dest->private;
> -		pci_attr = (struct vme_dma_pci *)src->private;
> +		vme_attr = dest->private;
> +		pci_attr = src->private;
>  	} else {
> -		vme_attr = (struct vme_dma_vme *)src->private;
> -		pci_attr = (struct vme_dma_pci *)dest->private;
> +		vme_attr = src->private;
> +		pci_attr = dest->private;
>  	}
>  
>  	/* Check we can do fullfill required attributes */
>   


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square, Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/