linux-kernel - Re: [PATCH 22/25] vme_tsi148: remove casts from void*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C31B637.6070604@ge.com>
Date:	Mon, 05 Jul 2010 11:38:47 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	Kulikov Vasiliy <segooon@...il.com>
CC:	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Julia Lawall <julia@...u.dk>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 22/25] vme_tsi148: remove casts from void*

Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
>   

Seems ok, cheers,

Signed-off-by: Martyn Welch <martyn.welch@...com>


> ---
>  drivers/staging/vme/bridges/vme_tsi148.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index abe88a3..4685a31 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -1649,7 +1649,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>  	/* Fill out source part */
>  	switch (src->type) {
>  	case VME_DMA_PATTERN:
> -		pattern_attr = (struct vme_dma_pattern *)src->private;
> +		pattern_attr = src->private;
>  
>  		entry->descriptor.dsal = pattern_attr->pattern;
>  		entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PAT;
> @@ -1663,7 +1663,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>  
>  		break;
>  	case VME_DMA_PCI:
> -		pci_attr = (struct vme_dma_pci *)src->private;
> +		pci_attr = src->private;
>  
>  		reg_split((unsigned long long)pci_attr->address, &address_high,
>  			&address_low);
> @@ -1672,7 +1672,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>  		entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PCI;
>  		break;
>  	case VME_DMA_VME:
> -		vme_attr = (struct vme_dma_vme *)src->private;
> +		vme_attr = src->private;
>  
>  		reg_split((unsigned long long)vme_attr->address, &address_high,
>  			&address_low);
> @@ -1701,7 +1701,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>  	/* Fill out destination part */
>  	switch (dest->type) {
>  	case VME_DMA_PCI:
> -		pci_attr = (struct vme_dma_pci *)dest->private;
> +		pci_attr = dest->private;
>  
>  		reg_split((unsigned long long)pci_attr->address, &address_high,
>  			&address_low);
> @@ -1710,7 +1710,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>  		entry->descriptor.ddat = TSI148_LCSR_DDAT_TYP_PCI;
>  		break;
>  	case VME_DMA_VME:
> -		vme_attr = (struct vme_dma_vme *)dest->private;
> +		vme_attr = dest->private;
>  
>  		reg_split((unsigned long long)vme_attr->address, &address_high,
>  			&address_low);
>   


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square, Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/