linux-kernel - Re: Fwd: Possible bug in net/ipv4/route.c?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1278334754.2877.173.camel@edumazet-laptop>
Date:	Mon, 05 Jul 2010 14:59:14 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: Fwd: Possible bug in net/ipv4/route.c?

Le lundi 05 juillet 2010 à 20:06 +0800, Herbert Xu a écrit :
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> >
> >> 2) The layer using skb->cb[] should clear this area after use and
> >> before handing the skb to another layer.  Ubicom should modify the
> >> driver to clear the skb->cb[] area before sending it up the line.
> >> 
> > 
> > This is the right option. If you use one word in cb[], only your driver
> > knows how to clear it efficiently.
> 
> Absolutely not! No protocol stack should rely on an external skb
> having a zero cb.
> 

Why do we clear full 48 bytes skb->cb[] in skb_alloc(), if no protocol
stack should rely it being zero ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/