[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100706132319.GT5381@redhat.com>
Date: Tue, 6 Jul 2010 09:23:19 -0400
From: Don Zickus <dzickus@...hat.com>
To: Kulikov Vasiliy <segooon@...il.com>
Cc: Kernel Janitors <kernel-janitors@...r.kernel.org>,
Frederic Weisbecker <fweisbec@...il.com>,
Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/watchdog: Initialize 'result'
On Mon, Jul 05, 2010 at 12:00:54PM +0400, Kulikov Vasiliy wrote:
> Variable on the stack is not initialized to zero, do it explicitly.
>
> This patch silences a compiler warning:
> kernel/watchdog.c:463: warning: ‘result’ may be used uninitialized in this function
Hmm, I thought I fixed that. oh well.
ACK.
>
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
> ---
> kernel/watchdog.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 91b0b26..613bc1f 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -460,7 +460,7 @@ static void watchdog_disable(int cpu)
> static void watchdog_enable_all_cpus(void)
> {
> int cpu;
> - int result;
> + int result = 0;
>
> for_each_online_cpu(cpu)
> result += watchdog_enable(cpu);
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists