linux-kernel - Re: [PATCH 2/7] block: push down BKL into .locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Jul 2010 10:36:15 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Christoph Hellwig <hch@...radead.org>,
	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, John Kacur <jkacur@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH 2/7] block: push down BKL into .locked_ioctl

On 2010-07-07 16:51, Arnd Bergmann wrote:
> As a preparation for the removal of the big kernel
> lock in the block layer, this removes the BKL
> from the common ioctl handling code, moving it
> into every single driver still using it.
>
> diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c
> index ad3ddef..fc593fb 100644
> --- a/drivers/message/i2o/i2o_block.c
> +++ b/drivers/message/i2o/i2o_block.c
> @@ -941,8 +930,7 @@ static const struct block_device_operations i2o_block_fops = {
>  	.owner = THIS_MODULE,
>  	.open = i2o_block_open,
>  	.release = i2o_block_release,
> -	.ioctl = i2o_block_ioctl,
> -	.compat_ioctl = i2o_block_ioctl,
> +	.locked_ioctl = i2o_block_ioctl,
>  	.getgeo = i2o_block_getgeo,
>  	.media_changed = i2o_block_media_changed
>  };

Hmm?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/