linux-kernel - Re: mmu notifier calls in apply_to_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100709173612.GF5741@random.random>
Date:	Fri, 9 Jul 2010 19:36:13 +0200
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: mmu notifier calls in apply_to_page_range()

On Fri, Jul 09, 2010 at 10:30:48AM -0700, Jeremy Fitzhardinge wrote:
> On 07/09/2010 09:22 AM, Andrea Arcangeli wrote:
> > mmu notifier only relevant for userland mappings, not kernel
> > mappings. I don't know about the xen use, but for vmalloc certainly it
> > can't be a problem to remove those two mmu notifier invalidates.
> >
> > Only bit that is worrysome is the mm == &init_mm
> > pte_alloc_kernel|pte_alloc_map_lock. That seems to imply it may also
> > be used to mangle over userland. But apparently all users are passing
> > &init_mm as expected. I guess if you remove the mm parameter and you
> > default to &init_mm definitely there will be no risk in removing the
> > mmu notifier range_start/end invalidates.
> >   
> 
> No, we do have some users which use it on user memory.  But those users
> are using it as part of their own mmu notifier backend, so the recursive
> calls are causing a problem.  My point is that anyone using
> apply_to_page_range should be making their own calls to mmu notifiers as
> appropriate to whatever they're doing.

Makes sense, it was hard in fact to see how it would cause any problem
for you considering nobody registers mmu notifiers into mm_init...

I've to say it's next to trivial for them to detect recursion and skip
the inner superflous call if they run it under a lock. But be careful
that pte_alloc/pmd_alloc and friends can block and break the mmu
notifier locking. I'm not really sure if it apply_to_page_range is a
sane interface to use inside mmu notifier methods considering it's
supposedly a blocking operation, caller must be careful to use that
inside a mmu notifier callback anyway...

I'm not opposed to removing it, I've been wondering if it made any
sense in the first place but then there was no point not to add
it. Just calling apply_to_page_range in non blocking context doesn't
look so good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/