linux-kernel - RE: [PATCH 1/2] regulator: tps6507x: allow driver to use DEFDCDC{2,3}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B85A65D85D7EB246BE421B3FB0FBB59301E7AAD278@dbde02.ent.ti.com>
Date:	Mon, 12 Jul 2010 16:19:03 +0530
From:	"Nori, Sekhar" <nsekhar@...com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"Aggarwal, Anuj" <anuj.aggarwal@...com>,
	Liam Girdwood <lrg@...mlogic.co.uk>
Subject: RE: [PATCH 1/2] regulator: tps6507x: allow driver to use
 DEFDCDC{2,3}_HIGH register


Hi Mark,

On Mon, Jul 12, 2010 at 16:10:45, Mark Brown wrote:
> On Mon, Jul 12, 2010 at 04:04:46PM +0530, Sekhar Nori wrote:
>
> > +
> > +   /* Does DCDC high or the low register defines output voltage? */
> > +   bool defdcdc_high;
>
> This should probably be "defdcdc_default" or something.  Presumably the
> line can also be wired to a GPIO and changed at runtime (otherwise the
> feature seems at best odd) and if support for that is implemented then
> this will change from being a static configuration in the platform data
> to something configured dynamically so the name would no longer make
> sense.

Quite right, it should be possible to change that line at runtime - though
none of the existing boards use that flexibility. Will change the name as
you have suggested.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/