lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Jul 2010 16:41:34 +0200 From: Sundar R IYER <sundar.iyer@...ricsson.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: "lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>, "sameo@...ux.intel.com" <sameo@...ux.intel.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>, Linus WALLEIJ <linus.walleij@...ricsson.com>, Bengt JONSSON <bengt.g.jonsson@...ricsson.com> Subject: RE: [PATCH v2 2/2] ux500: add ab8500-regulators machine specific data Mark, >It is extremely disappointing to see you reposting this without engaging >with my previous review at all. Sincere apologies. As I said, I tried to repost after fixing your comments; but my mistake that I didn't engage prior to the posting. >> +static struct regulator_consumer_supply ab8500_vaux1_consumers[] = { >> + { .dev = NULL, .supply = "vaux1", }, >> +}; > >All these supplies with NULL devices are bogus, supplies are in terms of >the device being supplied not the labels on the board. If you've got a >supply with no device and the name of the supply on either the regulator >or the board you're most likely doing it wrong. The only exception is >for supplies used in cpufreq since we don't have a struct device we can >use there. I had these supplies as NULL, so that later on, when we add devices for our platform, each developer can edit this file to hook up his own device. The reason I wanted this file in the patch set was to include the machine constraints for the regulators on AB8500. As admitted earlier, I will wait for your valuable comments before posting the next patch set. (Also, I will try to make sure(still learning) to post the next patches into the same thread.) Regards, Sundar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists