linux-kernel - Re: [PATCH] enable readback to get HPET working on ATI SB4x00, kernel 2.6.35

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100714181152.GB15651@aftab>
Date:	Wed, 14 Jul 2010 20:11:52 +0200
From:	Borislav Petkov <borislav.petkov@....com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Stephan Wolf <stephan@...zte-bankreihe.de>,
	<linux-kernel@...r.kernel.org>, <tglx@...utronix.de>,
	Andreas Herrmann <andreas.herrmann3@....com>
Subject: Re: [PATCH] enable readback to get HPET working on ATI SB4x00,
 kernel 2.6.35_rc5

From: Linus Torvalds <torvalds@...ux-foundation.org>
Date: Wed, Jul 14, 2010 at 09:13:39AM -0700

> On Wed, Jul 14, 2010 at 8:55 AM, Stephan Wolf
> <stephan@...zte-bankreihe.de> wrote:
> >
> >  After commit 30a564be9d9554c168a654eddc2165869cc0d7bf "x86, hpet: Restrict
> > read back to affected ATI chipsets" hpet did not work anymore on HP nx6325.
> > The machine hangs on booting until a keystroke was taken. After a short time
> > machine hangs again until next keystroke. Applying the following patch
> > solves the issue for me.
> 
> Ok, this makes sense. Bugs in the ATI chipset is why
> 'hpet_readback_cmp' exists in the first place. HOWEVER, clearly that
> commit changed it to be about too few ATI chipsets.
> 
> So right now, for
> 
>  - PCI_DEVICE_ID_ATI_SBX00_SMBUS:
>      force disable HPET MSI
>      force HPET readback
> 
>  - PCI_DEVICE_ID_ATI_IXP400_SMBU
>      force-enable HPET
>      ...and than your patch makes it force HPET readback
> 
> but that doesn't actually make much sense in the bigger picture,
> because there are other ATI chipsets that are related and presumably
> also affected. What about IXP[23]00_SMBUS? And what about the IXP7
> series (SBX00 is IXP6, afaik)?

Right, so the original commit introducing the readback did it for all
ATI chipsets: 72d43d9bc9210d24d09202eaf219eac09e17b339. We've been
running fine with it so far modulo the Intel ICH9 issue.

I'll try to find out which chipsets are actually affected but in the
meantime we might want to do a temporary fix by enabling the readback
back(!) on all ATI chipsets so that we don't uncover anymore bugs like
the one above, hmmm?

> And I added Andreas to the cc, maybe he knows what's up.

He'll be back on Mo.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/