linux-kernel - Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [2/5] Interrupt control bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100714.140433.59678649.davem@davemloft.net>
Date:	Wed, 14 Jul 2010 14:04:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sbhatewara@...are.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	pv-drivers@...are.com, ronghua@...are.com
Subject: Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [2/5] Interrupt
 control bitmap

From: Shreyas Bhatewara <sbhatewara@...are.com>
Date: Tue, 13 Jul 2010 17:48:04 -0700 (PDT)

> -	__le32		reserved[3];
> +	__le32		intrCtrl;
> +	__le32		reserved[2];
>  };
>  
 ...
> +	adapter->shared->devRead.intrConf.intrCtrl &= ~VMXNET3_IC_DISABLE_ALL;
 ...
> +	adapter->shared->devRead.intrConf.intrCtrl |= VMXNET3_IC_DISABLE_ALL;
 ...
> +	devRead->intrConf.intrCtrl |= VMXNET3_IC_DISABLE_ALL;

You need to use cpu_to_le32() and similar when accessing this value.

If you run "sparse" with endianness checking enabled you'll see
warnings showing alerting you to this issue...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/