| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100714.140718.115934967.davem@davemloft.net> Date: Wed, 14 Jul 2010 14:07:18 -0700 (PDT) From: David Miller <davem@...emloft.net> To: sbhatewara@...are.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, pv-drivers@...are.com, ronghua@...are.com, matthieu@...are.com Subject: Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [4/5] Do not reset when the device is not opened From: Shreyas Bhatewara <sbhatewara@...are.com> Date: Tue, 13 Jul 2010 17:49:52 -0700 (PDT) > > Do not reset when the device is not opened > > If a reset is scheduled, and the device goes thru close and open, it > may happen that reset and open may run in parallel. > The reset code now bails out if the device is not opened. > > Signed-off-by: Ronghua Zang <ronghua@...are.com> > Signed-off-by: Matthieu Bucchianeri <matthieu@...are.com> > Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com> Testing IFF_UP is just making your race hole a little smaller but it isn't fixing the problem. In fact, there really isn't any legitimate reason for a driver to test the IFF_UP state bit. netif_running() is the correct test, and asynchronous work queue things like resets should synchronize with open/close using the RTNL lock so that your test of netif_running() is a stable one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists