linux-kernel - Re: [PATCH RFC tip/core/rcu 27/30] rcu: apply ->rda changes to rcutree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100714211651.GF2417@linux.vnet.ibm.com>
Date:	Wed, 14 Jul 2010 14:16:51 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, dvhltc@...ibm.com, niv@...ibm.com,
	tglx@...utronix.de, peterz@...radead.org, rostedt@...dmis.org,
	Valdis.Kletnieks@...edu, dhowells@...hat.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH RFC tip/core/rcu 27/30] rcu: apply ->rda changes to
 rcutree_trace.c

On Wed, Jul 14, 2010 at 02:12:31PM -0700, Josh Triplett wrote:
> On Wed, Jul 14, 2010 at 01:10:01PM -0700, Paul E. McKenney wrote:
> > The print_rcu_pendings() function used the ->rda[] array, so this
> > commit makes it instead use per_cpu_ptr().
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > ---
> >  kernel/rcutree_trace.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
> > index 36c95b4..458e032 100644
> > --- a/kernel/rcutree_trace.c
> > +++ b/kernel/rcutree_trace.c
> > @@ -262,7 +262,7 @@ static void print_rcu_pendings(struct seq_file *m, struct rcu_state *rsp)
> >  	struct rcu_data *rdp;
> >  
> >  	for_each_possible_cpu(cpu) {
> > -		rdp = rsp->rda[cpu];
> > +		rdp = per_cpu_ptr(rsp->rda, cpu);
> >  		if (rdp->beenonline)
> >  			print_one_rcu_pending(m, rdp);
> >  	}
> 
> For the final version of this patchset, this should get squashed into
> the previous patch, right?  Otherwise, the state after the previous
> patch but before this one won't compile.

Makes sense, given that the earlier patch has not yet gone upstream.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/