linux-kernel - Re: [PATCH 6/8] xfs: fix unsigned underflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100715212116.GA7013@infradead.org>
Date:	Thu, 15 Jul 2010 17:21:16 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org, Alex Elder <aelder@....com>,
	Felix Blyakher <felixb@....com>, linux-kernel@...r.kernel.org,
	xfs@....sgi.com, xfs-masters@....sgi.com,
	Dave Chinner <dchinner@...hat.com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow

On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> below zero. So, check exact expression instead of map_len.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch@....de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/