linux-kernel - Re: [PATCH 6/8] xfs: fix unsigned underflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1279654533.1859.242.camel@doink>
Date:	Tue, 20 Jul 2010 14:35:33 -0500
From:	Alex Elder <aelder@....com>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	xfs@....sgi.com
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow

On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote:
> On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> > map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> > below zero. So, check exact expression instead of map_len.
> > 
> > Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 

Looks good to me too.  Do you want me to pull this
in via the XFS tree, or do you have other plans?

					-Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/