linux-kernel - Re: [PATCH] x86: kprobes: fix swapped segment registers in kretprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jul 2010 15:31:24 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Roland McGrath <roland@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Andrew Morton <akpm@...ux-foundation.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: kprobes: fix swapped segment registers in kretprobe

On Sun, Jul 18, 2010 at 3:11 PM, Roland McGrath <roland@...hat.com> wrote:
>
> [PATCH] x86: kprobes: fix swapped segment registers in kretprobe
>
> In commit f007ea26, the order of the %es and %ds segment registers
> got accidentally swapped, so synthesized 'struct pt_regs' frames
> have the two values inverted.  It's almost sure that these values
> never matter, and that they also never differ.  But wrong is wrong.

Heh, yes. ES and DS are almost guaranteed to be the same, or string
instructions act oddly. But I could imagine that some wine usage could
trigger this. Of course, you'd also have to have probes etc.

Regardless - pulled,

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/