linux-kernel - Re: [PATCH] x86: kprobes: fix swapped segment registers in kretprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C452BD6.7080901@hitachi.com>
Date:	Tue, 20 Jul 2010 13:53:42 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Roland McGrath <roland@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: kprobes: fix swapped segment registers in kretprobe

Roland McGrath wrote:
> The following changes since commit bea9a6d239cb2aa2ced4dcb0a05e1827ce61fa3d:
> 
>   Merge branch 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jlbec/ocfs2 (2010-07-18 10:09:25 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland.git x86/kprobes
> 
> Roland McGrath (1):
>       x86: kprobes: fix swapped segment registers in kretprobe
> 
>  arch/x86/kernel/kprobes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Thanks,
> Roland
> ---
> [PATCH] x86: kprobes: fix swapped segment registers in kretprobe
> 
> In commit f007ea26, the order of the %es and %ds segment registers
> got accidentally swapped, so synthesized 'struct pt_regs' frames
> have the two values inverted.  It's almost sure that these values
> never matter, and that they also never differ.  But wrong is wrong.

Oops, thanks Roland for finding it.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>


> 
> Signed-off-by: Roland McGrath <roland@...hat.com>
> ---
>  arch/x86/kernel/kprobes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
> index 345a4b1..675879b 100644
> --- a/arch/x86/kernel/kprobes.c
> +++ b/arch/x86/kernel/kprobes.c
> @@ -640,8 +640,8 @@ static int __kprobes kprobe_handler(struct pt_regs *regs)
>  	/* Skip cs, ip, orig_ax and gs. */	\
>  	"	subl $16, %esp\n"	\
>  	"	pushl %fs\n"		\
> -	"	pushl %ds\n"		\
>  	"	pushl %es\n"		\
> +	"	pushl %ds\n"		\
>  	"	pushl %eax\n"		\
>  	"	pushl %ebp\n"		\
>  	"	pushl %edi\n"		\
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/