linux-kernel - Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <op.vf3o6v067p4s8u@pikus>
Date:	Mon, 19 Jul 2010 19:21:57 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

On Mon, 19 Jul 2010 19:06:32 +0200, Alan Stern <stern@...land.harvard.edu> wrote:
>> 1/3: http://lkml.org/lkml/2010/7/8/317

> Ah, yes.  My personal taste would be to write fsg_string_serial_fill_n
> as an inline routine instead of as a macro, and not try to make it
> separate from fsg_string_serial_fill.

>> 2/3: http://lkml.org/lkml/2010/7/8/318

> I have only one objection to this patch: The new parameter's name
> should be "serial", not "serial_parm".  (Compare it to all the other
> parameter names.)

Will change the two tomorrow.

> As for the discussion between you and David...  I haven't tried to
> follow the details very carefully.  I get the impression that the two
> of you are talking past each other instead of coming to grips with a
> genuine issue.

I'm not entirely sure of what the issue with the patches is really.
It merely adds a serial number to the gadgets using MSF and that's all.

In any event, I am sure we will come to an agreement at one point. :)

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/