linux-kernel - Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <463626.69698.qm@web180301.mail.gq1.yahoo.com>
Date:	Mon, 19 Jul 2010 10:41:10 -0700 (PDT)
From:	David Brownell <david-b@...bell.net>
To:	Alan Stern <stern@...land.harvard.edu>,
	Michał Nazarewicz <m.nazarewicz@...sung.com>
Cc:	Greg KH <greg@...ah.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number



--- On Mon, 7/19/10, Michał Nazarewicz <m.nazarewicz@...sung.com> wrote:

> I'm not entirely sure of what the issue with
> the patches is really. It merely adds a serial
> number to the gadgets using MSF and that's all.

Go back and read what I wrote then.  The issue is
that THERE ALREADY IS SUCH A MECHANISM.  We neither
need or want another way to do it.  The answer is to
use the existing mechanism correctly.

Plus, you seem to be overlooking the basic need
(for userspace) to manage these IDs so they're
properly unique.  Two gadgets should never end up
using the same serial number.

I tire of repeating these basic points...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/