linux-kernel - Re: [PATCH 2/8] vmscan: tracing: Update trace event to track if page reclaim IO is for anon or file pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100719142436.GO13117@csn.ul.ie>
Date:	Mon, 19 Jul 2010 15:24:36 +0100
From:	Mel Gorman <mel@....ul.ie>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, Dave Chinner <david@...morbit.com>,
	Chris Mason <chris.mason@...cle.com>,
	Nick Piggin <npiggin@...e.de>, Rik van Riel <riel@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Wu Fengguang <fengguang.wu@...el.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [PATCH 2/8] vmscan: tracing: Update trace event to track if
	page reclaim IO is for anon or file pages

On Mon, Jul 19, 2010 at 10:15:01AM -0400, Christoph Hellwig wrote:
> On Mon, Jul 19, 2010 at 02:11:24PM +0100, Mel Gorman wrote:
> > It is useful to distinguish between IO for anon and file pages. This
> > patch updates
> > vmscan-tracing-add-trace-event-when-a-page-is-written.patch to include
> > that information. The patches can be merged together.
> 
> I think the trace would be nicer if you #define flags for both
> cases and then use __print_flags on them.  That'll also make it more
> extensible in case we need to add more flags later.
> 

Not a bad idea, I'll check it out. Thanks. The first flags would be;

RECLAIM_WB_ANON
RECLAIM_WB_FILE

Does anyone have problems with the naming?


> And a purely procedural question:  This is supposed to get rolled into
> the original patch before it gets commited to a git tree, right?
> 

That is my expectation.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/