linux-kernel - Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1007201005460.1631-100000@iolanthe.rowland.org>
Date:	Tue, 20 Jul 2010 10:07:35 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michał Nazarewicz <m.nazarewicz@...sung.com>
cc:	David Brownell <david-b@...bell.net>, Greg KH <greg@...ah.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

On Tue, 20 Jul 2010, [utf-8] MichaÅ Nazarewicz wrote:

> On Mon, 19 Jul 2010 19:41:10 +0200, David Brownell <david-b@...bell.net> wrote:
> >> I'm not entirely sure of what the issue with
> >> the patches is really. It merely adds a serial
> >> number to the gadgets using MSF and that's all.
> >
> > Go back and read what I wrote then.  The issue is
> > that THERE ALREADY IS SUCH A MECHANISM.  We neither
> > need or want another way to do it.  The answer is to
> > use the existing mechanism correctly.
> 
> There is no existing mechanism.  If the module does not set the
> iSerialNumber field the iSerialNumber module parameter won't work
> and I don't see any other way to set the string.  If there is one,
> please show it to me.

That's clearly a bug.  Change the code so that a module parameter will
always work, even if a function driver doesn't specify a serial number
string.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/