linux-kernel - Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1007201007510.1631-100000@iolanthe.rowland.org>
Date:	Tue, 20 Jul 2010 10:08:53 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michał Nazarewicz <m.nazarewicz@...sung.com>
cc:	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

On Tue, 20 Jul 2010, [utf-8] MichaÅ Nazarewicz wrote:

> > On Mon, 19 Jul 2010, [utf-8] Michalâ Nazarewicz wrote:
> >> 1/3: http://lkml.org/lkml/2010/7/8/317
> >> 	Adds serial to mass storage gadget and g_multi introducing
> >> 	fsg_string_serial_fill() macro used by abovementioned
> >> 	gadgets and file storage gadget.
> 
> On Mon, 19 Jul 2010 19:06:32 +0200, Alan Stern <stern@...land.harvard.edu> wrote:
> > Ah, yes.  My personal taste would be to write fsg_string_serial_fill_n
> > as an inline routine instead of as a macro, and not try to make it
> > separate from fsg_string_serial_fill.
> 
> Not sure what you meant by "make it separate from fsg_string_serial_fill".

I mean have a single function, called "fsg_string_serial_fill", instead 
of two separate macros called "fsg_string_serial_fill" and 
"fsg_string_serial_fill_n".

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/