linux-kernel - Re: [PATCH] KERNEL BUILD: Make the setlocalversion script POSIX-compliant.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100720231655.2226a38b@pomiocik.lan>
Date:	Tue, 20 Jul 2010 23:16:55 +0200
From:	Michał Górny <gentoo@...rny.alt.pl>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] KERNEL BUILD: Make the setlocalversion script
 POSIX-compliant.

On Tue, 20 Jul 2010 16:00:29 +0200
Michal Marek <mmarek@...e.cz> wrote:

> > There is one 'bashism' left which I wasn't able to fix -- the use of
> > 'test -ef'. I'm not aware of any POSIX equivalent of that.
> 
> Me neither, POSIX does not know stat(1) AFAICS. Does it matter in real
> life? Is there a distro that installs posh or a similarly strict shell
> as /bin/sh? It seems to work with dash after your changes.

I am not aware of any, and it does work with dash indeed. That's why I
have submitted the patch. I left that notice mostly because the actual
description suggested the script becomes 'POSIX-compliant'.

The second reason for that notice is that someone might want to fix
that sometime. But I guess the best way would be through complete
change of the check logic.

-- 
Best regards,
Michał Górny

<http://mgorny.alt.pl>
<xmpp:mgorny@...ber.ru>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/