linux-kernel - Re: [PATCH] USB: core: Choose configuration with lowest bConfigurationValue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1007221020440.1725-100000@iolanthe.rowland.org>
Date:	Thu, 22 Jul 2010 10:22:37 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <m.nazarewicz@...sung.com>
cc:	linux-usb@...r.kernel.org,
	Adam Kropelin <akropel1@...hester.rr.com>,
	Xiaofan Chen <xiaofanc@...il.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: core: Choose configuration with lowest bConfigurationValue

On Thu, 22 Jul 2010, Michal Nazarewicz wrote:

> This patch removes code from usb_choose_configuration()
> responsible for ignoring the first USB device configuration if
> its first interface is RNDIS.  Instead,
> usb_choose_configuration() chooses configuration with lowest
> bConfigurationValue.  Linux' Ethernet gadget uses a lower
> bConfigurationValue for the second configuration which is
> a CDC configuration so this code should choose configuration
> that suits Linux better.

I don't like this idea.  Choosing configs is a sensitive topic, since 
it is highly visible to users.  It should be changed minimally, if at 
all.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/