linux-kernel - Re: [PATCH] USB: core: Choose configuration with lowest bConfigurationValue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <op.vf80412e7p4s8u@pikus>
Date:	Thu, 22 Jul 2010 16:28:03 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	linux-usb@...r.kernel.org,
	Adam Kropelin <akropel1@...hester.rr.com>,
	Xiaofan Chen <xiaofanc@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: core: Choose configuration with lowest
 bConfigurationValue

> On Thu, 22 Jul 2010, Michal Nazarewicz wrote:
>> This patch removes code from usb_choose_configuration()
>> responsible for ignoring the first USB device configuration if
>> its first interface is RNDIS.  Instead,
>> usb_choose_configuration() chooses configuration with lowest
>> bConfigurationValue.  Linux' Ethernet gadget uses a lower
>> bConfigurationValue for the second configuration which is
>> a CDC configuration so this code should choose configuration
>> that suits Linux better.

On Thu, 22 Jul 2010 16:22:37 +0200, Alan Stern <stern@...land.harvard.edu> wrote:
> I don't like this idea.  Choosing configs is a sensitive topic, since
> it is highly visible to users.  It should be changed minimally, if at
> all.

Fine by me.  I've just posted it to show what I had in mind.

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/