linux-kernel - Re: [PATCH] Staging: comedi: comedidev: Fixed a macro definition code style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100723120747.GC32608@suse.de>
Date:	Fri, 23 Jul 2010 05:07:47 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Michael Jensen <emjay1988@...il.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: comedidev: Fixed a macro definition
	code style issue

On Fri, Jul 23, 2010 at 12:36:44PM +0200, Jiri Slaby wrote:
> On 07/23/2010 11:17 AM, Michael Jensen wrote:
> > On Fri, Jul 23, 2010 at 6:53 PM, Jiri Slaby <jirislaby@...il.com> wrote:
> >>
> > <snip>
> >> Hmm, does this compile?
> >>
> > I did build the comedi directory (as per Greg's "Write and submit your
> > first kernel patch" video), and didn't get any errors (once I'd done
> > the configuration)...
> > 
> > Did I miss something?
> 
> Then the macro is probably unused (or unused in your configuration).
> Either way, the macro seems to be intended for use in the top-level
> scope, so do { } while (0) cannot be used there.

I think we might have now removed all users of that macro, so it should
just be deleted.

Michael, can you do that instead of the do/while stuff here, as that is
not a valid change.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/