linux-kernel - Re: Input: twl40300-keypad - fix handling of "all ground" rows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100724080551.22893752@infradead.org>
Date:	Sat, 24 Jul 2010 08:05:51 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	torvalds@...ux-foundation.org, dmitry.torokhov@...il.com
Subject: Re: Input: twl40300-keypad - fix handling of "all ground" rows

On Thu, 22 Jul 2010 19:59:09 GMT
Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote:

> Gitweb:
> http://git.kernel.org/linus/3fea60261e73dbf4a51130d40cafcc8465b0f2c3
> Commit:     3fea60261e73dbf4a51130d40cafcc8465b0f2c3 Parent:
> c25f7b763cc35a249232ce612a36a811b0e263f9 Author:     Dmitry Torokhov
> <dmitry.torokhov@...il.com> AuthorDate: Tue Jul 20 20:25:35 2010 -0700
> Committer:  Dmitry Torokhov <dmitry.torokhov@...il.com>
> CommitDate: Tue Jul 20 20:29:48 2010 -0700
> 
>     Input: twl40300-keypad - fix handling of "all ground" rows
>     
>     The Nokia RX51 board code
> (arch/arm/mach-omap2/board-rx51-peripherals.c) defines a key map for
> the matrix keypad keyboard. The hardware seems to use all of the 8
> rows and 8 columns of the keypad, although not all possible locations
> are used. 



> +	KEY(4, 8, KEY_10),
> +
>  	KEY(5, 0, KEY_Y),
> +	KEY(5, 8, KEY_11),
>

This patch, as merged, is broken. Nowhere in the kernel are KEY_10 and
KEY_11 defined.... so this causes a compile failure.

Are you sure you didn't mean KEY_F10 / KEY_F11 ?


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/