linux-kernel - Re: [PATCH] i2c: QUP based bus driver for Qualcomm MSM chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C4B0201.9060106@codeaurora.org>
Date:	Sat, 24 Jul 2010 20:38:49 +0530
From:	Trilok Soni <tsoni@...eaurora.org>
To:	Kenneth Heitke <kheitke@...eaurora.org>
CC:	khali@...ux-fr.org, ben-linux@...ff.org,
	linux-arm-msm@...r.kernel.org, Crane Cai <crane.cai@....com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	srinidhi kasagar <srinidhi.kasagar@...ricsson.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: QUP based bus driver for Qualcomm MSM chipsets

Hi Ken,

> 
>>
>>> +
>>> +    if (!pdata->msm_i2c_config_gpio) {
>>> +        dev_err(&pdev->dev, "config_gpio function not initialized\n");
>>> +        ret = -ENOSYS;
>>> +        goto err_config_failed;
>>> +    }
>>
>> I don't agree here. What if I do all the gpio configuration from the bootloader itself,
>> because I know that the device I am working on is production device and don't change
>> its configuration, then why I should provide the pdata hooks from the board files?
> 
> The reason that this hook is required is so that the driver can enable and disable the GPIOs as needed (although we currently only enable them).
> 
>>
>> Please also specify what are the operations we are doing in the msm_i2c_config_gpio?
> 
> Takes ownership of the GPIOs that are needed and assigns the ownership to the i2c controller.  The drive strength is also set.

Right, so due to these reasons I prefer not to have __must__ have check for pdata->msm_i2c_config_gpio hook's unavailability. It
might happen that some of the systems do all these ownership and pad muxing into the bootloader itself.

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/