[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100727161819.cf6feab1.akpm@linux-foundation.org>
Date: Tue, 27 Jul 2010 16:18:19 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: monstr@...str.eu
Cc: rostedt@...dmis.org, linux-kernel@...r.kernel.org,
tglx@...utronix.de, mingo@...e.hu, linux-arch@...r.kernel.org
Subject: Re: [PATCH] asm-generic: Use raw_local_irq_save/restore instead
local_irq_save/restore
On Mon, 26 Jul 2010 10:49:50 +0200
Michal Simek <monstr@...str.eu> wrote:
> start/stop_critical_timing function for preemptirqsoff, preemptoff
> and irqsoff tracers contains atomic_inc and atomic_dec operations.
>
> Atomic operations used local_irq_save/restore macros to ensure
> atomic access but they are traced by the same function which is causing
> recursion problem.
>
> The reason is when these tracers are turn ON then local_irq_save/restore
> macros are changed in include/linux/irqflags.h to call trace_hardirqs_on/off
> which call start/stop_critical_timing.
>
> Microblaze was affected because use generic atomic implementation.
Seems that this will also affect blackfin, mn10300 and score. I guess
they aren't supporting tracing yet?
> Signed-off-by: Michal Simek <monstr@...str.eu>
> Acked-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
hm, I wonder how my signoff got there. Doesn't matter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists