linux-kernel - Re: [PATCH 2/5] staging:ti dspbridge: remove unnecessary check for NULL pointer in cmm.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Jul 2010 10:04:57 -0500
From:	Nishanth Menon <nm@...com>
To:	"Ramos Falcon, Ernesto" <ernesto@...com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"Ramirez Luna, Omar" <omar.ramirez@...com>,
	"ohad@...ery.com" <ohad@...ery.com>,
	"ameya.palande@...ia.com" <ameya.palande@...ia.com>,
	"felipe.contreras@...ia.com" <felipe.contreras@...ia.com>,
	"Guzman Lugo, Fernando" <fernando.lugo@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 2/5] staging:ti dspbridge: remove unnecessary check for
 NULL pointer in cmm.c

Ramos Falcon, Ernesto had written, on 07/28/2010 09:40 AM, the following:
> Remove unnecessary check for NULL pointer in cmm.c.
> 
> Signed-off-by: Ernesto Ramos <ernesto@...com>
> ---
>  drivers/staging/tidspbridge/pmgr/cmm.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/tidspbridge/pmgr/cmm.c b/drivers/staging/tidspbridge/pmgr/cmm.c
> index 8e808d9..874ed64 100644
> --- a/drivers/staging/tidspbridge/pmgr/cmm.c
> +++ b/drivers/staging/tidspbridge/pmgr/cmm.c
> @@ -992,16 +992,12 @@ int cmm_xlator_create(struct cmm_xlatorobject **xlator,
>  int cmm_xlator_delete(struct cmm_xlatorobject *xlator, bool force)
>  {
>  	struct cmm_xlator *xlator_obj = (struct cmm_xlator *)xlator;
> -	int status = 0;
>  
>  	DBC_REQUIRE(refs > 0);
>  
> -	if (xlator_obj)
> -		kfree(xlator_obj);
> -	else
> -		status = -EFAULT;
> +	kfree(xlator_obj);
>  
> -	return status;
> +	return 0;
>  }
>  
>  /*
which kind of begs the question - does this function need to any longer 
return int?

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/