linux-kernel - Re: Please pull my perf.git urgent branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10DB64E9-7D7E-497C-9044-C2649D22981D@freescale.com>
Date:	Wed, 28 Jul 2010 11:15:38 -0500
From:	Kumar Gala <kumar.gala@...escale.com>
To:	Paul Mackerras <paulus@...ba.org>
CC:	Scott Wood <scottwood@...escale.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: Please pull my perf.git urgent branch


On Jul 27, 2010, at 11:47 PM, Paul Mackerras wrote:

> On Tue, Jul 27, 2010 at 11:28:54AM -0500, Scott Wood wrote:
> 
>> Doesn't the setting of .period need to be maintained (it is in the other
>> powerpc perf_event implementation that this is derived from)?
> 
> Gah, yes it does.
> 
>> I don't see how this is a security fix -- the existing initializer above
>> should zero-fill the fields that are not explicitly initialized.  In fact,
>> it's taking other fields that were previously initialized to zero and is
>> making them uninitialized, since perf_sample_data_init only sets addr and
>> raw.
> 
> So I misunderstood how an initializer for an automatic struct works.
> Brown paper bag time for me... :(
> 
> Regarding the other fields, I assume Peter et al. have checked that
> they don't need to be cleared, so it's a microoptimization to not
> clear them.
> 
>> CCing linuxppc-dev on the original patch would have been nice...
> 
> True, but at least I can blame Peter Z. for that. :)
> 
> Kumar and Ben, how do you want to proceed on this one?

If we aren't concerned about an oops being generated lets just submit a patch for 2.6.36.

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/