linux-kernel - Re: [PATCH 07/10] ALSA: sb: check get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Jul 2010 12:31:00 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	Tejun Heo <tj@...nel.org>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] ALSA: sb: check get_user() return value

At Wed, 28 Jul 2010 20:40:51 +0400,
Kulikov Vasiliy wrote:
> 
> get_user() may fail, if so return -EFAULT.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>

Thanks, applied this one (with one additional fix for get_user() there).


Takashi

> ---
>  sound/isa/sb/emu8000_pcm.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/isa/sb/emu8000_pcm.c b/sound/isa/sb/emu8000_pcm.c
> index ccedbfe..ae6fa9f 100644
> --- a/sound/isa/sb/emu8000_pcm.c
> +++ b/sound/isa/sb/emu8000_pcm.c
> @@ -433,7 +433,8 @@ static int emu8k_transfer_block(struct snd_emu8000 *emu, int offset, unsigned sh
>  	while (count > 0) {
>  		unsigned short sval;
>  		CHECK_SCHEDULER();
> -		get_user(sval, buf);
> +		if (get_user(sval, buf))
> +			return -EFAULT;
>  		EMU8000_SMLD_WRITE(emu, sval);
>  		buf++;
>  		count--;
> @@ -525,7 +526,8 @@ static int emu8k_pcm_copy(struct snd_pcm_substream *subs,
>  	while (count-- > 0) {
>  		unsigned short sval;
>  		CHECK_SCHEDULER();
> -		get_user(sval, buf);
> +		if (get_user(sval, buf))
> +			return -EFAULT;
>  		EMU8000_SMLD_WRITE(emu, sval);
>  		buf++;
>  		if (rec->voices > 1) {
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/