linux-kernel - Re: [PATCH 08/10] oss: midi_synth: check get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Jul 2010 12:31:32 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	Roel Kluin <roel.kluin@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] oss: midi_synth: check get_user() return value

At Wed, 28 Jul 2010 20:41:17 +0400,
Kulikov Vasiliy wrote:
> 
> get_user() may fail, if so return -EFAULT.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>

Applied now.  Thanks.


Takashi


> ---
>  sound/oss/midi_synth.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/oss/midi_synth.c b/sound/oss/midi_synth.c
> index 3bc7104..3c09374 100644
> --- a/sound/oss/midi_synth.c
> +++ b/sound/oss/midi_synth.c
> @@ -523,7 +523,9 @@ midi_synth_load_patch(int dev, int format, const char __user *addr,
>  	{
>  		unsigned char   data;
>  
> -		get_user(*(unsigned char *) &data, (unsigned char __user *) &((addr)[hdr_size + i]));
> +		if (get_user(data,
> +		    (unsigned char __user *)(addr + hdr_size + i)))
> +			return -EFAULT;
>  
>  		eox_seen = (i > 0 && data & 0x80);	/* End of sysex */
>  
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/