linux-kernel - Re: [PATCH 2/4] posix-cpu-timers: Introduction of wall clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100730133031.76b8f99f@dhcp-lab-109.englab.brq.redhat.com>
Date:	Fri, 30 Jul 2010 13:30:31 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Tomasz Buchert <tomasz.buchert@...ia.fr>
Cc:	linux-kernel@...r.kernel.org,
	Daniel Walker <dwalker@...eaurora.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH 2/4] posix-cpu-timers: Introduction of wall clocks

On Fri, 30 Jul 2010 11:57:45 +0200
Tomasz Buchert <tomasz.buchert@...ia.fr> wrote:
  
> -	read_lock(&tasklist_lock);
> +	rcu_read_lock();
>  	p = find_task_by_vpid(pid);
>  	if (!p || !(POSIX_CLOCK_PERTHREAD(which_clock) ?
>  		   same_thread_group(p, current) : thread_group_leader(p))) {
>  		error = -EINVAL;
>  	}
> -	read_unlock(&tasklist_lock);
> +	rcu_read_unlock();

IIRC thread_group_leader(p) is wrong here, has_group_leader_pid(p)
should be used. Beside this change alone should be a separate patch,
not part of a "new feature" patch.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/