linux-kernel - Re: [PATCH 01/13] AppArmor: misc. base functions and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimJp3fxBox7wFYxVJySKrM12mSVYYOjiXcHt_YC@mail.gmail.com>
Date:	Fri, 30 Jul 2010 18:01:39 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	John Johansen <john.johansen@...onical.com>,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Nick Piggin <npiggin@...e.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>, laijs@...fujitsu.com
Subject: Re: [PATCH 01/13] AppArmor: misc. base functions and defines

On Fri, Jul 30, 2010 at 5:24 PM, Changli Gao <xiaosuo@...il.com> wrote:
> On Fri, Jul 30, 2010 at 6:53 PM, Pekka Enberg <penberg@...helsinki.fi> wrote:
>> On Fri, Jul 30, 2010 at 1:01 PM, John Johansen
>>>
>>> vfree can sleep, and skipping the schedule_work parts won't work for
>>> apparmor as many of these allocations are being freed via rcu callbacks
>>> as most of our object life cycles are dependent on cred refcounting.
>>
>> Can someone point me to where vfree() actually sleeps? I'm unable to
>> find the exact spot.
>
> http://lxr.linux.no/linux+v2.6.34.1/mm/vmalloc.c#L1405 . vfree ->
> __vunmap, vunmap -> __vunmap, and there is a might_sleep() function in
> vunmap.

Yes, but that doesn't answer my question. Where's the actual call-site
that can sleep? I can't find it!

> BTW: I'll respin the kvmalloc patch later.

Great!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/