linux-kernel - Re: [PATCH] PCI: Do not run NVidia quirks related to MSI with MSI disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100730094755.7f53b7d8@virtuousgeek.org>
Date:	Fri, 30 Jul 2010 09:47:55 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-pci@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: Do not run NVidia quirks related to MSI with MSI
 disabled

On Fri, 23 Jul 2010 22:19:55 +0200
"Rafael J. Wysocki" <rjw@...k.pl> wrote:

> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> There is no reason to run NVidia-specific quirks related to HT MSI
> mappings with MSI disabled via pci=nomsi, so make
> __nv_msi_ht_cap_quirk() return immediately in that case.
> 
> This allows at least one machine to boot 100% of the time with
> pci=nomsi (it still doesn't boot reliably without that).
> 
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=16443 .
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>  drivers/pci/quirks.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-2.6/drivers/pci/quirks.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/quirks.c
> +++ linux-2.6/drivers/pci/quirks.c
> @@ -2390,6 +2390,9 @@ static void __devinit __nv_msi_ht_cap_qu
>  	int pos;
>  	int found;
>  
> +	if (!pci_msi_enabled())
> +		return;
> +
>  	/* check if there is HT MSI cap or enabled on this device */
>  	found = ht_check_msi_mapping(dev);

applied to linux-next with a cc: stable.  Thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/