linux-kernel - Re: [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <op.vgn0zfyq7p4s8u@pikus>
Date:	Fri, 30 Jul 2010 18:48:41 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCHv5 2/3] USB: gadget: Use new composite features in some
 gadgets

> --- On Wed, 7/28/10, Michal Nazarewicz <m.nazarewicz@...sung.com> wrote:
>> use the new features of composite framework.  Because it
>> handles default strings there is no longer the need for
>> the gadgets drivers to handle many of the strings.

On Fri, 30 Jul 2010 00:21:18 +0200, David Brownell <david-b@...bell.net> wrote:
> The gadgets should always identify the same, and
> thus handle their strings -- *unless* module params
> are applied by users to override those defaults.

This is not how many gadgets seem to work at least as
far as the iManufacturer is concerned which is usually built
at run-time as "Linux <version> with <gadget-name>".

The patch does not change the behaviour of the gadget since all
it does is take advantage of code put in composite.c in the 1/2
patch.  Therefore, modified gadgets will still use the same
strings only code that handles string ID reservation is placed in
composite.c now (since it needs to be there to fix the module
parameters anyway).

>> -static unsigned short gfs_vendor_id    = 0x0525;    /* XXX NetChip */
>> -static unsigned short gfs_product_id   = 0xa4ac;    /* XXX */

> Look -- you can't assign NetChip numbers!!!

/me ashamed

Obviously, you're absolutely right.  I left the XXX mark to remember
to clear the situation with the IDs but then completely forgot about
it after g_multi got pulled. (It's especially bad since there is a
conflict with hid.c).

So, to fix the situation, I need to ask Greg for the IDs?

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/