linux-kernel - Re: [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100730165450.GA4943@kroah.com>
Date:	Fri, 30 Jul 2010 09:54:50 -0700
From:	Greg KH <greg@...ah.com>
To:	Michał Nazarewicz <m.nazarewicz@...sung.com>
Cc:	David Brownell <david-b@...bell.net>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCHv5 2/3] USB: gadget: Use new composite features in some
 gadgets

On Fri, Jul 30, 2010 at 06:48:41PM +0200, Michał Nazarewicz wrote:
> >>-static unsigned short gfs_vendor_id    = 0x0525;    /* XXX NetChip */
> >>-static unsigned short gfs_product_id   = 0xa4ac;    /* XXX */
> 
> >Look -- you can't assign NetChip numbers!!!
> 
> /me ashamed
> 
> Obviously, you're absolutely right.  I left the XXX mark to remember
> to clear the situation with the IDs but then completely forgot about
> it after g_multi got pulled. (It's especially bad since there is a
> conflict with hid.c).
> 
> So, to fix the situation, I need to ask Greg for the IDs?

Yes you do.  We shouldn't be using _any_ netchip ids anymore now that we
have our own vendor id assigned to us.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/