linux-kernel - Re: [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1280684100.4430.8.camel@heimdal.trondhjem.org>
Date:	Sun, 01 Aug 2010 13:35:00 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && 
 !CONFIG_NFS_V3

On Sun, 2010-08-01 at 10:10 -0700, Linus Torvalds wrote:
> On Sat, Jul 31, 2010 at 11:44 PM, Ingo Molnar <mingo@...e.hu> wrote:
> >
> > FYI, these commits introduced a build failure on x86:
> >
> >  fs/nfs/file.c:508: error: implicit declaration of function ‘nfs_commit_inode’
> 
> Grr. Trond?

Sorry. I was intending to put that declaration outside the #ifdef. The
stub function is still declared in fs/nfs/write.c

> > @@ -492,11 +492,9 @@ extern int nfs_writeback_done(struct rpc_task *, struct nfs_write_data *);
> >  extern int nfs_wb_all(struct inode *inode);
> >  extern int nfs_wb_page(struct inode *inode, struct page* page);
> >  extern int nfs_wb_page_cancel(struct inode *inode, struct page* page);
> > -#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
> >  extern int  nfs_commit_inode(struct inode *, int);
> >  extern struct nfs_write_data *nfs_commitdata_alloc(void);
> >  extern void nfs_commit_free(struct nfs_write_data *wdata);
> > -#endif
> 
> No, I think perhaps the '#if' line should just be moved down one line.
> The other function still only exist for V3/V4, it's just
> nfs_commit_inode() that is available (as a stub that just returns 0)
> for V2.
> 
> But maybe that stub should be made an inline function or #define?
> 
> Trond?

I'll convert it into an inlined stub just as it was prior to commit
8fc795f703c5138e1a8bfb88c69f52632031aa6a.

Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/