linux-kernel - Re: [PATCH RFC 3/4] Paravirtualized spinlock implementation for KVM guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C56E221.6050800@goop.org>
Date:	Mon, 02 Aug 2010 08:20:01 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Avi Kivity <avi@...hat.com>
CC:	vatsa@...ux.vnet.ibm.com, Marcelo Tosatti <mtosatti@...hat.com>,
	Gleb Natapov <gleb@...hat.com>, linux-kernel@...r.kernel.org,
	npiggin@...e.de, kvm@...r.kernel.org, bharata@...ibm.com,
	Balbir Singh <balbir@...ibm.com>,
	Jan Beulich <JBeulich@...ell.com>
Subject: Re: [PATCH RFC 3/4] Paravirtualized spinlock implementation for KVM
 guests

  On 08/02/2010 01:48 AM, Avi Kivity wrote:
>  On 07/26/2010 09:15 AM, Srivatsa Vaddagiri wrote:
>> Paravirtual spinlock implementation for KVM guests, based heavily on 
>> Xen guest's
>> spinlock implementation.
>>
>>
>> +
>> +static struct spinlock_stats
>> +{
>> +    u64 taken;
>> +    u32 taken_slow;
>> +
>> +    u64 released;
>> +
>> +#define HISTO_BUCKETS    30
>> +    u32 histo_spin_total[HISTO_BUCKETS+1];
>> +    u32 histo_spin_spinning[HISTO_BUCKETS+1];
>> +    u32 histo_spin_blocked[HISTO_BUCKETS+1];
>> +
>> +    u64 time_total;
>> +    u64 time_spinning;
>> +    u64 time_blocked;
>> +} spinlock_stats;
>
> Could these be replaced by tracepoints when starting to spin/stopping 
> spinning etc?  Then userspace can reconstruct the histogram as well as 
> see which locks are involved and what call paths.

Unfortunately not; the tracing code uses spinlocks.

(TBH I haven't actually tried, but I did give the code an eyeball to 
this end.)

     J

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/