linux-kernel - Re: [PATCH 1/2] x86, setup: reorgize the early_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100802203659.GH5544@lenovo>
Date:	Tue, 3 Aug 2010 00:36:59 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Pekka Enberg <penberg@...helsinki.fi>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] x86, setup: reorgize the early_console_setup

On Mon, Aug 02, 2010 at 01:30:17PM -0700, Yinghai Lu wrote:
...
> >> +	/* make sure if it is copied already */
> >> +	if (boot_params.hdr.version)
> >> +		return;
> >> +
> > 
> > And Yinghai, lets be more verbose here a bit, since for those who will
> > be reading this code later might be non-obvious why we have checked for
> > 'version' here. I guess something like "an easy way to check if boot_params
> > were already copied". Actually it's clean from commit message but I think
> > we first read code comments and commit messages after, agreed? ;-)
> 
> will change to 
> 
>         /*
>          * hdr.version is always not 0, so check it to see
>          *  if boot_params is copied or not.
>          */
> 
> will resend this patch after memblock x86 changes.
> 
> YH
> 

ok, thanks!

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/