linux-kernel - Re: [PATCH] nconfig: add search support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57767.148.87.67.132.1280784139.squirrel@www.xenotime.net>
Date:	Mon, 2 Aug 2010 14:22:19 -0700 (PDT)
From:	rdunlap@...otime.net
To:	nir.tzachar@...il.com
Cc:	mmarek@...e.cz, rdunlap@...otime.net, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, nir.tzachar@...il.com,
	sam@...nborg.org, trapdoor6@...il.com, justinmattock@...il.com
Subject: Re: [PATCH] nconfig: add search support

On Sun, August 1, 2010 12:20 am, nir.tzachar@...il.com wrote:
> From: Nir Tzachar <nir.tzachar@...il.com>
>
>
> Remove the old hotkeys feature, and replace by a regular string search.
> From nconfig help:
>
>
> Pressing '/' triggers search mode. nconfig does regular string match,
> case insensitive, starting at the begining of each menu line. Pressing
> Enter highlights the next match, Backspace removes one character from
> the match string. Pressing either '/' again or ESC exits search mode.
>
> Rebind the '/' key (which allowed to search for symbols) to F8
>
>
> Signed-off-by: Nir Tzachar <nir.tzachar@...il.com>
> ---
> scripts/kconfig/nconf.c |  261
> ++++++++++++++++++++++-------------------------
> scripts/kconfig/nconf.h |    3 +- 2 files changed, 125 insertions(+), 139
> deletions(-)


A few other comments:

These help text lines should end with a period:

  Pressing SpaceBar toggles between the above options

  <Esc> always leaves the current window


The F-key help along the bottom line should be forced to fit
into 80 columns.  F9 (exit) especially should be visible.


This F3 should be F5:

  Press <Esc>, <F3> or <left-arrow> to go back one menu,


How about we make nconfig the default in linux-next
so that it will be used more?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/