linux-kernel - Re: [PATCH] nconfig: add search support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik4PmwBrP9DEoOUad6=-cf8tC=vMU7AmoAMBDzy@mail.gmail.com>
Date:	Tue, 3 Aug 2010 07:37:44 +0300
From:	Nir Tzachar <nir.tzachar@...il.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	mmarek@...e.cz, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, sam@...nborg.org,
	trapdoor6@...il.com, justinmattock@...il.com
Subject: Re: [PATCH] nconfig: add search support

On Mon, Aug 2, 2010 at 7:32 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
> On Sun,  1 Aug 2010 10:20:33 +0300 nir.tzachar@...il.com wrote:
>
>> From: Nir Tzachar <nir.tzachar@...il.com>
>>
>> Remove the old hotkeys feature, and replace by a regular string search.
>> From nconfig help:
>>
>> Pressing '/' triggers search mode. nconfig does regular string match, case
>> insensitive, starting at the begining of each menu line.
>
> What is a "regular string match"?
> That's not the same as a regular expression match, right?
>
> Maybe it's a "simple string match"?

strcasecmp. I've considered using regex or fnmatch, but it seemed an overkill.

>> Pressing Enter highlights the next match, Backspace removes one character from
>> the match string. Pressing either '/' again or ESC exits search mode.
>>
>> Rebind the '/' key (which allowed to search for symbols) to F8
>>
>> Signed-off-by: Nir Tzachar <nir.tzachar@...il.com>
>> ---
>>  scripts/kconfig/nconf.c |  261 ++++++++++++++++++++++-------------------------
>>  scripts/kconfig/nconf.h |    3 +-
>>  2 files changed, 125 insertions(+), 139 deletions(-)
>>
>> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
>> index 762caf8..2a7cb37 100644
>> --- a/scripts/kconfig/nconf.c
>> +++ b/scripts/kconfig/nconf.c
>> @@ -41,9 +41,12 @@ static const char nconf_readme[] = N_(
>>  "   pressing <Enter> of <right-arrow>. Use <Esc> or <left-arrow> to go back.\n"
>>  "   Submenus are designated by \"--->\".\n"
>>  "\n"
>> -"   Shortcut: Press the option's highlighted letter (hotkey).\n"
>> -"             Pressing a hotkey more than once will sequence\n"
>> -"             through all visible items which use that hotkey.\n"
>> +"   Searching: pressing '/' triggers search mode. nconfig does a\n"
>> +"              regular string match, case insensitive, starting at\n"
>> +"              the begining of each menu line.\n"
>> +"              Pressing Enter highlights the next match, Backspace\n"
>> +"              removes one character from the match string.\n"
>> +"              Pressing either '/' again or ESC exits search mode.\n"
>>  "\n"
>>  "   You may also use the <PAGE UP> and <PAGE DOWN> keys to scroll\n"
>>  "   unseen options into view.\n"
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/