linux-kernel - Re: [PATCH -v3 2/2] x86: more early console output from compressed/misc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C574AB6.5030403@zytor.com>
Date:	Mon, 02 Aug 2010 15:46:14 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Cyrill Gorcunov <gorcunov@...il.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Pekka Enberg <penberg@...helsinki.fi>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v3 2/2] x86: more early console output from	compressed/misc.c

First, I'm not quite sure which 1/2 patch you're expecting this to be
compiled against.

On 08/02/2010 03:30 PM, Yinghai Lu wrote:
>  
> +	if (debug) {
> +		putstr("decompress_kernel:\n");
> +		printf("  input: [0x%lx-0x%lx], output: 0x%lx, heap: [0x%lx-0x%lx]\n",
> +			 (unsigned long)input_data,
> +			 (unsigned long)input_data + input_len - 1,
> +			 (unsigned long)output,
> +			 (unsigned long)heap,
> +			 (unsigned long)heap + BOOT_HEAP_SIZE - 1);
> +	}
> +

This seems to be the only user of printf() in the code.  As such, I
really suspect it's not worth pulling in all of printf().  I'd be
willing to be convinced, but if so I need (a) a concrete usage case, and
(b) it should be a separate patch.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/