linux-kernel - Re: [PATCH] USB-serial dummy cable driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201008032021.07504.marek.vasut@gmail.com>
Date:	Tue, 3 Aug 2010 20:21:07 +0200
From:	Marek Vasut <marek.vasut@...il.com>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
	nm127@...email.hu, linux-kernel@...r.kernel.org,
	maxinbjohn@...il.com, forest.bond@...postembedded.com,
	vijaykumar@...ogic.com
Subject: Re: [PATCH] USB-serial dummy cable driver

Dne Út 3. srpna 2010 19:49:12 Greg KH napsal(a):
> On Tue, Aug 03, 2010 at 07:36:39PM +0200, Marek Vasut wrote:
> > Dne Út 3. srpna 2010 18:38:26 Greg KH napsal(a):
> > > On Tue, Aug 03, 2010 at 06:14:15PM +0200, Marek Vasut wrote:
> > > > Dne Út 3. srpna 2010 00:47:18 Greg KH napsal(a):
> > > > > On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote:
> > > > > > This driver is used to implement USB-serial like behaviour over
> > > > > > dummy
> > > > > > 
> > > > > > USB cables. These are used in the following devices:
> > > > > > 	Funsoft Serial USB driver
> > > > > > 	Genesys Logic GL620USB USB Laplink cable
> > > > > > 	HP4x (48/49) Serial cable
> > > > > > 	Motorola phones
> > > > > > 	Siemens USB-MPI Serial USB driver
> > > > > > 	ViVOpay USB Serial Driver
> > > > > > 	ZIO Motherboard USB driver
> > > > > 
> > > > > I like the idea, but not the name :)
> > > > 
> > > > Please don't expect miracles from me after 26 hours without sleep ;-)
> > > > 
> > > > > Ideally, all of these would be able to be handled by the usb-serial
> > > > > generic driver directly.
> > > > 
> > > > I just noticed that one. Stupid me.
> > > > 
> > > > > But really, having these multiple drivers is a good thing, they
> > > > > properly convey to the user what the device is, and it gives these
> > > > > developers and companies a sense of ownership over the code, and
> > > > > that matters at times.
> > > > > 
> > > > > So you lost the names of the devices with this patch, which isn't
> > > > > good.
> > > > 
> > > > Sheesh ... that's true, but having pile of copies of the same code is
> > > > not good either.
> > > 
> > > I agree, that's why I said it should be reduced.
> > > 
> > > > Can't we then just deprecate all these drivers and set correct udev
> > > > rules?
> > > 
> > > udev can not change the name of the device in sysfs, or the name in the
> > > kernel of the device.
> > 
> > That's right, but it can bind the generic driver with the hardware. And
> > who would care about the driver name, really ? The interface just
> > appears and that's what matters (to me and probably to users) ...
> 
> There are persistant device links in /dev/serial/ that might care about
> the driver name.  We don't want to break them, right?

We can start a slow migration though. Eg. push the serial-generic as a way-to-go 
so the distro teams can pick this change and incorporate it into their stuff.

Maybe just mark all those drivers as "DEPRECATED" and add a note there "use 
generic-serial".
> 
> thanks,
> 
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/