linux-kernel - Re: [PATCH 2/2] genhd, efi: add efi partition metadata to hd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimsSJSGLrwbJ05F9dqvvB2GxpE5a+T4J4pTGH6r@mail.gmail.com>
Date:	Wed, 4 Aug 2010 09:45:22 -0500
From:	Will Drewry <wad@...omium.org>
To:	John Stoffel <john@...ffel.org>
Cc:	Kay Sievers <kay.sievers@...y.org>, linux-kernel@...r.kernel.org,
	Jens Axboe <axboe@...nel.dk>, Karel Zak <kzak@...hat.com>,
	Tejun Heo <tj@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 2/2] genhd, efi: add efi partition metadata to hd_structs

On Wed, Aug 4, 2010 at 9:27 AM, John Stoffel <john@...ffel.org> wrote:
>>>>>> "Kay" == Kay Sievers <kay.sievers@...y.org> writes:
>
> Kay> On Wed, Aug 4, 2010 at 00:27, Will Drewry <wad@...omium.org> wrote:
>>> On Tue, Aug 3, 2010 at 4:54 PM, Kay Sievers <kay.sievers@...y.org> wrote:
>
>>>> Did you already test to put a lookup-call to the in-kernel mounter, if
>>>> we use some special partition table uuid identifier for root=? That
>>>> would be nice to see, if all that works as expected, and we can get to
>>>> the data we collect.
>>>
>>> Not yet, but I'd like to have it working there (and in my
>>> device-mapper target) as soon as possible.  Hopefully, I'll have that
>>> done pretty soon and I'll repost the series inclusive of an init:
>>> change.
>
> Kay> Nice.
>
>>> Any preferences on the variable? I'll start with your example of
>>> PARTUUID=, but that follows the initramfs model (UUID=) and not the
>>> existing magic root devices (/dev/nfs, /dev/ram).
>>> /dev/by-part-uuid/XXX... doesn't seem super-friendly though :)
>
> Kay> Yeah, this stuff does not really fit in to the path notation
> Kay> stuff, unless we use the udev-style link names, which some people
> Kay> like to avoid, and prefer some more abstract thing here.
>
> Kay> We have UUID=, LABEL= for mount and fstab, I think PARTUUID=,
> Kay> PARTLABEL= matches this.
>
> Ugh, why do we care whether a UUID refers to a disk or a partition?
> It should be unique no matter what, so just do /dev/uuid/XXXX and call
> it done.

Since these are supposed to be _unique_ it seems that any reference to
a uuid should be fair game.  And if a root=/dev/uuid/XXX makes it to
an initramfs environment, then that'll be able to easily check if the
UUID refers to a filesystem uuid or not.

I can roll that into the next version unless there's specific complaints.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/