linux-kernel - Re: [PATCH v2 1/3] block, partition: add partition_meta_info to hd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinqNuKkvk8NPpUyr5VZuNmgLJzju9N0KTPvPdxn@mail.gmail.com>
Date:	Wed, 4 Aug 2010 09:46:00 -0500
From:	Will Drewry <wad@...omium.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>,
	Jens Axboe <axboe@...nel.dk>, Karel Zak <kzak@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>, Jan Blunck <jblunck@...e.de>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH v2 1/3] block, partition: add partition_meta_info to 
	hd_struct

On Wed, Aug 4, 2010 at 2:57 AM, Tejun Heo <tj@...nel.org> wrote:
> Hello,
>
> On 08/04/2010 04:04 AM, Will Drewry wrote:
>> This changes adds a partition_meta_info struct which itself contains a
>> union of structures that provide partition table specific metadata.
>>
>> This change leaves the union empty. The subsequent patch includes an
>> implementation for CONFIG_EFI_PARTITION-based metadata.
>>
>> Signed-off-by: Will Drewry <wad@...omium.org>
>
> Generally looks good to me.
>
>>  /*
>>   * add_gd_partition adds a partitions details to the devices partition
>>   * description.
>> @@ -12,6 +13,7 @@ struct parsed_partitions {
>>               sector_t from;
>>               sector_t size;
>>               int flags;
>> +             struct partition_meta_info *info;
>>       } parts[DISK_MAX_PARTS];
>
> But you can just embed the structure here.  It's a temp data structure
> to make things easier for individual partition scan code.  There's no
> need to save bytes.

Great - that'll simplify the code more.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/