| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1280940512.16380.4.camel@maxim-laptop> Date: Wed, 04 Aug 2010 19:48:32 +0300 From: Maxim Levitsky <maximlevitsky@...il.com> To: Alex Dubov <oakad@...oo.com> Cc: LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader. On Wed, 2010-08-04 at 00:57 -0700, Alex Dubov wrote: > I see two immediate problems with this patch: > > 1. On cosmetic level, custom debug macros should not be employed. Device > core already have this functionality (dynamic debug levels and such). Please, > use dev_dbg and friends for print-outs. This allows much easier control for debug. Single module parameter is enough to adjust it. This helps me help users. (Eg, kernel compilation is out of question) > > 2. On a structural level, I'd rather prefer host drivers to not start their > own threads. If you look at both current host implementations, they operate > in callback fashion. Apart from saving some resources, this reduces the > amount of problems encountered during suspend/resume and shutdown. This isn't possible. Hardware doesn't support interrupts on memstick bus changes, it only supports DMA done from/to internal FIFO, and DMA it only possible for 512 byte TPCs. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists