linux-kernel - Re: [PATCHv3 02/16] pps: declare variables where they are used in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100805090517.GF26615@gundam.enneenne.com>
Date:	Thu, 5 Aug 2010 11:05:17 +0200
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Alexander Gordeev <lasaine@....cs.msu.su>
Cc:	linux-kernel@...r.kernel.org,
	"Nikita V. Youshchenko" <yoush@...msu.su>,
	linuxpps@...enneenne.com, john stultz <johnstul@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joonwoo Park <joonwpark81@...il.com>
Subject: Re: [PATCHv3 02/16] pps: declare variables where they are used in
	switch

On Thu, Aug 05, 2010 at 01:06:39AM +0400, Alexander Gordeev wrote:
> Move variable declarations where they are used in pps_cdev_ioctl.
> 
> Signed-off-by: Alexander Gordeev <lasaine@....cs.msu.su>
> ---
>  drivers/pps/pps.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c
> index ca5183b..c76afb9 100644
> --- a/drivers/pps/pps.c
> +++ b/drivers/pps/pps.c
> @@ -61,8 +61,6 @@ static long pps_cdev_ioctl(struct file *file,
>  {
>  	struct pps_device *pps = file->private_data;
>  	struct pps_kparams params;
> -	struct pps_fdata fdata;
> -	unsigned long ticks;
>  	void __user *uarg = (void __user *) arg;
>  	int __user *iuarg = (int __user *) arg;
>  	int err;
> @@ -136,7 +134,9 @@ static long pps_cdev_ioctl(struct file *file,
>  
>  		break;
>  
> -	case PPS_FETCH:
> +	case PPS_FETCH: {
> +		struct pps_fdata fdata;
> +
>  		pr_debug("PPS_FETCH: source %d\n", pps->id);
>  
>  		err = copy_from_user(&fdata, uarg, sizeof(struct pps_fdata));
> @@ -149,6 +149,8 @@ static long pps_cdev_ioctl(struct file *file,
>  		if (fdata.timeout.flags & PPS_TIME_INVALID)
>  			err = wait_event_interruptible(pps->queue, pps->go);
>  		else {
> +			unsigned long ticks;
> +
>  			pr_debug("timeout %lld.%09d\n",
>  					(long long) fdata.timeout.sec,
>  					fdata.timeout.nsec);
> @@ -185,7 +187,7 @@ static long pps_cdev_ioctl(struct file *file,
>  			return -EFAULT;
>  
>  		break;
> -
> +	}
>  	default:
>  		return -ENOTTY;
>  		break;
> -- 
> 1.7.1

I don't like such definitions but I know it is just a stylistic
problem, so it's ok for me. :)

Acked-by: Rodolfo Giometti <giometti@...ux.it>

-- 

GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/