linux-kernel - Re: [PATCHv3 01/16] pps: trivial fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100805085758.GE26615@gundam.enneenne.com>
Date:	Thu, 5 Aug 2010 10:57:58 +0200
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Alexander Gordeev <lasaine@....cs.msu.su>
Cc:	linux-kernel@...r.kernel.org,
	"Nikita V. Youshchenko" <yoush@...msu.su>,
	linuxpps@...enneenne.com, john stultz <johnstul@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCHv3 01/16] pps: trivial fixes

On Thu, Aug 05, 2010 at 01:06:38AM +0400, Alexander Gordeev wrote:
> Here are some very trivial fixes combined:
>  * add macro definitions to protect header file from including several times
>  * remove declaration for an unexistent array
>  * fix typos
> 
> Signed-off-by: Alexander Gordeev <lasaine@....cs.msu.su>
> ---
>  drivers/pps/kapi.c         |    2 +-
>  include/linux/pps_kernel.h |    7 ++++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
> index 1aa02db..55f3961 100644
> --- a/drivers/pps/kapi.c
> +++ b/drivers/pps/kapi.c
> @@ -324,7 +324,7 @@ void pps_event(int source, struct pps_ktime *ts, int event, void *data)
>  		captured = ~0;
>  	}
>  
> -	/* Wake up iif captured somthing */
> +	/* Wake up if captured something */
>  	if (captured) {
>  		pps->go = ~0;
>  		wake_up_interruptible(&pps->queue);
> diff --git a/include/linux/pps_kernel.h b/include/linux/pps_kernel.h
> index e0a193f..c930d11 100644
> --- a/include/linux/pps_kernel.h
> +++ b/include/linux/pps_kernel.h
> @@ -18,6 +18,9 @@
>   *   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>   */
>  
> +#ifndef LINUX_PPS_KERNEL_H
> +#define LINUX_PPS_KERNEL_H
> +
>  #include <linux/pps.h>
>  
>  #include <linux/cdev.h>
> @@ -71,7 +74,6 @@ struct pps_device {
>  
>  extern spinlock_t pps_idr_lock;
>  extern struct idr pps_idr;
> -extern struct timespec pps_irq_ts[];
>  
>  extern struct device_attribute pps_attrs[];
>  
> @@ -87,3 +89,6 @@ extern void pps_unregister_source(int source);
>  extern int pps_register_cdev(struct pps_device *pps);
>  extern void pps_unregister_cdev(struct pps_device *pps);
>  extern void pps_event(int source, struct pps_ktime *ts, int event, void *data);
> +
> +#endif /* LINUX_PPS_KERNEL_H */
> +
> -- 
> 1.7.1

Acked-by: Rodolfo Giometti <giometti@...ux.it>

-- 

GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/